what is the real necessary change

Time: 五月 16, 2013
Category: Kernel


[PATCH] vfs: no need to check about IS_IMMUTABLE in do_fallocate

From: Ashish Sangwan <a.sangwan <at> samsung.com>

In do_fallocate, first there is check for FMODE_WRITE and after that
there is second check for IS_IMMUTABLE.
A file cannot be opened in write mode if the corresponding inode is
immutable, hence the second check is not required.

Signed-off-by: Ashish Sangwan <a.sangwan <at> samsung.com>
Signed-off-by: Namjae Jeon <namjae.jeon <at> samsung.com>
 fs/open.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/fs/open.c b/fs/open.c
index 8c74100..939e402 100644
--- a/fs/open.c
+++ b/fs/open.c
 <at>  <at>  -245,9 +245,6  <at>  <at>
 	int do_fallocate(struct file *file, int mode, loff_t offset, loff_t len)
 	if (mode & FALLOC_FL_PUNCH_HOLE && IS_APPEND(inode))
 		return -EPERM;

-	if (IS_IMMUTABLE(inode))
-		return -EPERM;
 	 * Revalidate the write permissions, in case security policy has
 	 * changed since the files were opened.




Leave a Comment